Skip to content

[eas-cli] Add --max-idle-time-minutes flag to eas simulator - #4156

Open
szdziedzic wants to merge 1 commit into
mainfrom
szdziedzic-claude/eas-simulator-idle-timeout-2c8cf2
Open

[eas-cli] Add --max-idle-time-minutes flag to eas simulator#4156
szdziedzic wants to merge 1 commit into
mainfrom
szdziedzic-claude/eas-simulator-idle-timeout-2c8cf2

Conversation

@szdziedzic

@szdziedzic szdziedzic commented Aug 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Why

EAS Simulator sessions cost money while they run. Today a session that nobody uses keeps running until its max duration. This PR adds the CLI half of an opt-in idle timeout: the user sets it when starting the session, and EAS stops the session after that many minutes without activity.

Related PRs:

How

Add new --max-idle-time-minutes integer flag. It is passed as maxIdleTimeMinutes on CreateDeviceRunSessionInput.

Test Plan

CI passes

@szdziedzic
szdziedzic force-pushed the szdziedzic-claude/eas-simulator-idle-timeout-2c8cf2 branch from 5d7a255 to 95419a1 Compare August 5, 2026 18:18
@codecov

codecov Bot commented Aug 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.53%. Comparing base (6cbddf5) to head (0c916da).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4156   +/-   ##
=======================================
  Coverage   63.53%   63.53%           
=======================================
  Files        1028     1028           
  Lines       47033    47033           
  Branches     9884     9884           
=======================================
  Hits        29879    29879           
  Misses      17053    17053           
  Partials      101      101

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@szdziedzic szdziedzic mentioned this pull request Aug 5, 2026
Merged
@szdziedzic
szdziedzic force-pushed the szdziedzic-claude/eas-simulator-idle-timeout-2c8cf2 branch from 95419a1 to e933995 Compare August 5, 2026 21:22
@szdziedzic szdziedzic changed the title [eas-cli][build-tools] Add opt-in max idle time for EAS Simulator sessions [eas-cli] Add --max-idle-time-minutes flag to eas simulator Aug 5, 2026
@brentvatne brentvatne added the ai-review Commits pushed to PRs with this label be automatically reviewed. label Aug 5, 2026
@github-actions

github-actions Bot commented Aug 5, 2026 •
edited
Loading

Copy link
Copy Markdown

🤖 AI code review

Decision: Ready for human review

Overall PR risk: Low. The change is additive: it adds one optional integer flag, --max-idle-time-minutes, to the eas simulator command and forwards it as maxIdleTimeMinutes on the existing CreateDeviceRunSessionInput. When a user omits the flag, the value is undefined, so the mutation payload matches today's payload, and the session lifecycle, polling loop, and Ctrl+C handling stay the same. No reviewer found a correctness, consistency, or security issue. The blast radius is limited to the hidden, experimental eas simulator command, and rollback only needs removing the flag and the one payload line.

No findings.

This review is advisory — it never blocks a merge and never auto-approves.

@szdziedzic
szdziedzic force-pushed the szdziedzic-claude/eas-simulator-idle-timeout-2c8cf2 branch 3 times, most recently from e933995 to bca121e Compare August 11, 2026 10:56
@szdziedzic
szdziedzic marked this pull request as ready for review August 11, 2026 11:07
@szdziedzic
szdziedzic requested a review from sjchmiela August 11, 2026 11:07
@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
packages/eas-cli/** @douglowder

Generated by CodeMention

Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead.

@szdziedzic @claude
[eas-cli] Add --max-idle-time-minutes flag to eas simulator
0c916da 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@szdziedzic
szdziedzic force-pushed the szdziedzic-claude/eas-simulator-idle-timeout-2c8cf2 branch from bca121e to 0c916da Compare August 18, 2026 11:18
@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjchmiela sjchmiela Awaiting requested review from sjchmiela

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

ai-review Commits pushed to PRs with this label be automatically reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@szdziedzic @brentvatne